Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LambdaInvokeFunctionOperator payload parameter type #32259

Merged
merged 16 commits into from
Jul 3, 2023

Conversation

eladi99
Copy link
Contributor

@eladi99 eladi99 commented Jun 29, 2023

Closes: #32227


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg
Copy link

boring-cyborg bot commented Jun 29, 2023

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@eladi99
Copy link
Contributor Author

eladi99 commented Jun 29, 2023

This PR is meant to solve this issue I've opened: #32227

InvokeLambdaFunctionOperator now accepts bytes or str for its payload argument.
If the value is str, it is converted into bytes using encode() method.

This will fix incompatibility with corresponding boto3 functionality while not breaking the API.

@eladkal eladkal changed the title Fixing issue - Fix payload parameter of amazon LambdaCreateFunctionOperator Fix LambdaInvokeFunctionOperator payload parameter type Jun 29, 2023
@vincbeck
Copy link
Contributor

You need to update the unit tests. But otherwise, LGTM

Copy link
Contributor

@eladkal eladkal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Please add test coverage for this change

@eladi99
Copy link
Contributor Author

eladi99 commented Jul 1, 2023

@eladkal @vincbeck can you refer me to the tests that should be updated?
Should I add some new once, and if so -- where?

@eladkal
Copy link
Contributor

eladkal commented Jul 1, 2023

@eladkal @vincbeck can you refer me to the tests that should be updated? Should I add some new once, and if so -- where?

Sure.

The hook is tested with string payload

you should add a new test / extend existed test to also test byte payload.
I think in this case probably just making the test accept multiple inputs (strings and bytes) using @pytest.mark.parametrize will do the trick (you can find many examples for this in the source code)

The same goes for testing the operator class

payload=json.dumps({"TestInput": "Testdata"}),

@eladi99
Copy link
Contributor Author

eladi99 commented Jul 2, 2023

@eladkal pls take a another look

@eladkal
Copy link
Contributor

eladkal commented Jul 2, 2023

Static checks are failing

@eladkal eladkal merged commit 5c72bef into apache:main Jul 3, 2023
@boring-cyborg
Copy link

boring-cyborg bot commented Jul 3, 2023

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LambdaInvokeFunctionOperator expects wrong type for payload arg
5 participants