-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix LambdaInvokeFunctionOperator
payload parameter type
#32259
Fix LambdaInvokeFunctionOperator
payload parameter type
#32259
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
|
This PR is meant to solve this issue I've opened: #32227 InvokeLambdaFunctionOperator now accepts bytes or str for its payload argument. This will fix incompatibility with corresponding boto3 functionality while not breaking the API. |
LambdaInvokeFunctionOperator
payload parameter type
…-invoke-lambda-operator-parameter
You need to update the unit tests. But otherwise, LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Please add test coverage for this change
…-invoke-lambda-operator-parameter
Sure. The hook is tested with string payload
you should add a new test / extend existed test to also test byte payload. The same goes for testing the operator class
|
…-invoke-lambda-operator-parameter
@eladkal pls take a another look |
…-invoke-lambda-operator-parameter
Static checks are failing |
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
Closes: #32227
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.